Updating to Godot 4.3 ?

[Phazorknight]

Wanted to do a general poll how people feel about updating to Godot 4.3?

As the release is still very new, I haven't looked into it a lot yet, but there might be some things that could benefit COGITO directly (like the cyclical reference updates).
Other than that I'm in no rush.

[mrezai]

I tested COGITO in Godot 4.3 and this is the results:

It seems animations should be updated because of these errors:

Meshes under ViewmodelSpace node like wieldable's meshes doesn't show in the scene for example after equip a wieldable. Maybe related to this change: https://godotengine.org/article/introducing-reverse-z/

[Phazorknight]

Thanks for the quick check.
I'll definitely expect some issues and errors to come up, but this seems fixable.
Wanted to give the way we're currently instantiating wiedlables another look anyway cause I feel it's not very performant.

[MathieuBK]

I'm currently using the Jolt addon for handling physics, and as of now, Godot 4.3 doesn't seem to be compatible with it. While I'm unsure about the compatibility of other addons, migrating to 4.3 could potentially introduce unpredictable issues. I believe the most prudent choice at this time is to stick with 4.2.

[Phazorknight]

That makes sense. I think there's quite a few users who use Jolt with Cogito.
Though I'm also pretty sure, Jolt will update before I'll be able to update. 😇

[JohnnyThunder2]

Alright so, there are like 3 issues, 1 of them I already fixed and submitted my pull request.

The other two have something to do the player script having errors, just decided to comment that code out and so far it's working but that's probably because I haven't run into issues yet.

And the final issue, and this one I'm working on, is the wieldables don't display correctly and render behind a levels geometry (I'm using cyclops but observed this same effect on CSG geometry as well) Temporary fix is to turn on "no_depth_test" on the material of each wieldable, but obviously that's not the final solution and I'm still trying to figure out how everything works in Godot right now and why the game is rendering the level geometry first.

I'm new to this but getting my pull request accepted was a lot of fun!

If I can contribute in the future I will, thank you.

[niefia]

Had a look at running it in 4.3 to see how much needs doing.

Only real issues I encountered was the Viewmodel space shader . Didn't encounter any player script error so unsure if that might have been changed/fixed already?
I did have errors with the weapon animation, but animations can be fixed pretty easily by just disabling the unused tracks

Found that it looks like the shader code used may be based on this: https://www.youtube.com/watch?v=OmodsHOxGQU and the updated 4.3 reverse Z version posted in the comments seemed to work to show the model, but had some issues with clipping still.

[Phazorknight]

Hey everyone,
So I created a branch for the Godot 4.3 update: https://github.com/Phazorknight/Cogito/tree/godot-4-3

I fixed the animation errors and updated the viewport shader. Overall it seems to just... work? But haven't tested a lot yet.
Please feel free to try the branch and see how it goes.

but had some issues with clipping still.

@niefia I see what you mean, seems like it only occurs on certain meshes (like the swing in the laboratory). Will investigate a bit more.

[niefia]

Tested and I'm still getting the clipping everywhere with it, not just on specific meshes.

To see what I mean make sure to test it in the Lobby as the Lab has ledges around most walls, and those ledges prevent you from getting close enough for a clipping issue to happen.

It's definitely working better than no viewmodel shader at all, but has a lot more clipping issues than it does in 4.2

[niefia]

Ok so done some more testing and have something that works.
Essentially just change to larger values in this section of the injected shader code so here:

if(viewmodel_enabled){
			POSITION.z = mix(POSITION.z, 0, -2.999);
		}

This works to stop the clipping issue, can't guarantee that's the best value or even why that value works better tbh but it does seem to stop the clipping issue.

[Phazorknight]

Yeah, this is where I would've looked. I've pushed an update with changing the z value to this. An almost 3m offset should be good enough for most wieldables (unless someone creates a lance or something :D ), so should be good enough for now.

[Phazorknight]

Hey everyone,

Since Cogito is now officially updated to run on Godot 4.3, I'm closing this thread.
Please open an issue if you run into any problems.