Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with slide audio when sliding -> jumping -> landing #131

Closed
Phazorknight opened this issue Mar 31, 2024 · 4 comments
Closed

Error with slide audio when sliding -> jumping -> landing #131

Phazorknight opened this issue Mar 31, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@Phazorknight
Copy link
Owner

@ac-arcana

I've encountered this issue and was able to replicate it reliably:

When I sprint, slide and jump while sliding, the slide sound keeps playing (should probably stop as soon as the player is in the air).
If the sound is still playing by the time I land, the game errors:

player.gd: line 764: slide_audio_player.stop() - Cannot call method `stop` on a previously freed instance.
@Phazorknight Phazorknight added the bug Something isn't working label Mar 31, 2024
@ac-arcana
Copy link
Collaborator

I'll look at it tomorrow :)

@Phazorknight
Copy link
Owner Author

Sounds good, no rush!

@ac-arcana
Copy link
Collaborator

#135

@Phazorknight
Copy link
Owner Author

Sweet, thanks for this fix!
Closing this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants