Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opened doors break upon scene transition #181

Closed
aronand opened this issue Apr 29, 2024 · 5 comments
Closed

Opened doors break upon scene transition #181

aronand opened this issue Apr 29, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@aronand
Copy link
Contributor

aronand commented Apr 29, 2024

Cogito and Godot Engine Version:
Godot: 4.2.1
Cogito: 6d9f37e

Description:
Opened doors visually break if a scene is switched. This seems to impact all opened doors in one way or another.

Reproduction steps:

  1. Open all the doors in the first level of demo map
  2. Move to the laboratory scene
  3. Move back to the initial scene
  4. Observe that the doors now exhibit the following oddities: opened door looks closed, opened door's position is slightly wrong, or the opened doors position is so wrong, that it no longer shows up in the map.

Expected behavior:
The doors should retain their position if their state has been altered.

Screenshots:
closed_open_door
Door looks visually closed, but state is open

cupboard_doors
Doors look closed, but are also positioned wrong

vanished_door
Door has vanished from the scene, most likely somewhere outside the level

@aronand aronand added the bug Something isn't working label Apr 29, 2024
@aronand
Copy link
Contributor Author

aronand commented Apr 29, 2024

In the original demo map, a lot of the pieces end up in the middle of the gun range section:
demo_map_01

The drawers however seem to work as intended:
demo_map_02

Unrelated to the doors, the note on the wall disappears even when nothing has been interacted with:
demo_map_note

@Phazorknight
Copy link
Owner

Thanks for flagging this: was able to reproduce and am looking into it.

@Phazorknight Phazorknight self-assigned this Apr 30, 2024
@Phazorknight
Copy link
Owner

Ok, this should be fixed in 2ee8503

When I implemented the state loader for the sliding door that can close automatically, I made that the default for ALL doors if they were open. This update fixes this and implements two methods that improve readability to set door states more easily.

@aronand
Copy link
Contributor Author

aronand commented May 1, 2024

Doors now seem to function as intended 👍 the note still disappears however, in both original and new test map (albeit of course that is not what the ticket is directly about).

@Phazorknight
Copy link
Owner

@aronand yeah, there's actually something weird going one with Cogito Objects that are based on StaticBody3Ds. Will make a separate issue about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants