You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ironically, while pull request #32 fixed issue #66 "graphics install broken for some users" by using shutil instead of dir_util to copy graphics trees, it corrupted it for everyone.
I discovered this when I published 40.24-r8 of my pack a few days ago, and started seeing complaints of wrong graphics - dwarves with corpse sprites, and animals represented by letters.
Thanks to VCS, which I love even more than before, I've nailed my commit 950bb3e as the culprit.
Now I've just got to work out - and test - a solution that can be applied to tip, and test that too. Should be good to go tomorrow, and I'll release a fix soon after!
[Issue created by PeridexisErrant: 2015-04-06]
[Last updated on bitbucket: 2015-04-07]
[Comment created by PeridexisErrant: 2015-04-06]
So going back to dir_util in core/mods L#366 fixes the problem. However I'd prefer to understand and fix the bug, instead of just going back to the old (and itself problematic) method. Off to the docs!
[Comment created by PeridexisErrant: 2015-04-07]
Resolved by pull request #37
The text was updated successfully, but these errors were encountered:
Ironically, while pull request #32 fixed issue #66 "graphics install broken for some users" by using shutil instead of dir_util to copy graphics trees, it corrupted it for everyone.
I discovered this when I published 40.24-r8 of my pack a few days ago, and started seeing complaints of wrong graphics - dwarves with corpse sprites, and animals represented by letters.
Thanks to VCS, which I love even more than before, I've nailed my commit 950bb3e as the culprit.
Now I've just got to work out - and test - a solution that can be applied to tip, and test that too. Should be good to go tomorrow, and I'll release a fix soon after!
[Issue created by PeridexisErrant: 2015-04-06]
[Last updated on bitbucket: 2015-04-07]
[Comment created by PeridexisErrant: 2015-04-06]
So going back to dir_util in
core/mods
L#366 fixes the problem. However I'd prefer to understand and fix the bug, instead of just going back to the old (and itself problematic) method. Off to the docs![Comment created by PeridexisErrant: 2015-04-07]
Resolved by pull request #37
The text was updated successfully, but these errors were encountered: