Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphics install was corrupted between 0.9.4 and 0.9.5 #112

Closed
Pidgeot opened this issue Apr 4, 2020 · 0 comments
Closed

Graphics install was corrupted between 0.9.4 and 0.9.5 #112

Pidgeot opened this issue Apr 4, 2020 · 0 comments
Labels

Comments

@Pidgeot
Copy link
Owner

Pidgeot commented Apr 4, 2020

Ironically, while pull request #32 fixed issue #66 "graphics install broken for some users" by using shutil instead of dir_util to copy graphics trees, it corrupted it for everyone.

I discovered this when I published 40.24-r8 of my pack a few days ago, and started seeing complaints of wrong graphics - dwarves with corpse sprites, and animals represented by letters.

Thanks to VCS, which I love even more than before, I've nailed my commit 950bb3e as the culprit.

Now I've just got to work out - and test - a solution that can be applied to tip, and test that too. Should be good to go tomorrow, and I'll release a fix soon after!

[Issue created by PeridexisErrant: 2015-04-06]
[Last updated on bitbucket: 2015-04-07]

[Comment created by PeridexisErrant: 2015-04-06]
So going back to dir_util in core/mods L#366 fixes the problem. However I'd prefer to understand and fix the bug, instead of just going back to the old (and itself problematic) method. Off to the docs!

[Comment created by PeridexisErrant: 2015-04-07]
Resolved by pull request #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant