Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake FindOpenSubdiv module does not recognize RC builds #82

Closed
jcowles opened this issue Oct 17, 2016 · 6 comments
Closed

CMake FindOpenSubdiv module does not recognize RC builds #82

jcowles opened this issue Oct 17, 2016 · 6 comments

Comments

@jcowles
Copy link

jcowles commented Oct 17, 2016

Steps to Reproduce

  1. Build OpenSubdiv RC2
  2. Run CMake configuration for USD

Note that OpenSubdiv is recognized as version "2" (vs. 3.1.0.RC2).

This is due to the regex in the CMake config, I have a local fix if there is interest in making the RC builds work.

@jtran56
Copy link

jtran56 commented Oct 17, 2016

Filed as internal issue #138795.

@c64kernal
Copy link
Contributor

Thanks Jeremy. We have a fix coming to dev soon.

@meshula
Copy link
Member

meshula commented Oct 17, 2016

@jcowles could you summarize your fix briefly here? I've got a couple of questions about this already.

@c64kernal
Copy link
Contributor

Hey Nick and Jeremy -- the fix is now in dev. Let us know if you have any questions.

@jcowles
Copy link
Author

jcowles commented Oct 18, 2016

Thanks for the quick fix!

@meshula I basically did what takahito did, but I chopped off _RC* instead.

@meshula
Copy link
Member

meshula commented Oct 18, 2016

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants