Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in GreedyProjectionTriangulation::connectPoint #1220

Closed
donno opened this issue Apr 30, 2015 · 3 comments
Closed

Bug in GreedyProjectionTriangulation::connectPoint #1220

donno opened this issue Apr 30, 2015 · 3 comments

Comments

@donno
Copy link

donno commented Apr 30, 2015

The following line found in pcl::GreedyProjectionTriangulation::connectPoint looks very suspicious and like a potential bug:
if ((ffn_[sfn_[next_index]] = ffn_[current_index_]) || (sfn_[sfn_[next_index]] == ffn_[current_index_]))
The = looks like it should be ==, given that the rest of the statement is the similar looking if statement in the other case in the switch statement..

gp3.hpp

@taketwo
Copy link
Member

taketwo commented Apr 30, 2015

Indeed, looks suspicious. However, if we want to change this line, it's better to actually understand the logic behind and not base the decision only on "look-alike" reasoning.

@stale
Copy link

stale bot commented May 19, 2020

Marking this as stale due to 30 days of inactivity. It will be closed in 7 days if no further activity occurs.

@stale stale bot added the status: stale label May 19, 2020
@donno
Copy link
Author

donno commented May 20, 2020

Two years later, @puzzlepaint pointed out that the same thing that I did here but in pull request #1879.

You signed on of the pull request and it has been accepted so this issue has been resolved.

@donno donno closed this as completed May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants