Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate macro definition in instantiate.hpp header #1924

Closed
PeterSchuebel opened this issue Jul 4, 2017 · 0 comments · Fixed by #2396
Closed

duplicate macro definition in instantiate.hpp header #1924

PeterSchuebel opened this issue Jul 4, 2017 · 0 comments · Fixed by #2396

Comments

@PeterSchuebel
Copy link
Contributor

This is not an actual build issue right now, but I noticed that the pre-processor macro PCL_INSTANTIATE_PRODUCT_IMPL is defined twice in the instantiate.hpp header, if PCL_NO_PRECOMPILE is defined for the build. As I said, in practice this is currently not causing build problems. At the moment that macro is not used anywhere, if PCL_NO_PRECOMPILE is defined. It just looks unclean.

Your Environment

  • Operating System and version: Windows 8.1 64 bit
  • Compiler: Microsoft Visual Studio 2013
  • PCL Version: 1.8.0-dev

Expected Behavior

Macro is only defined once.

Current Behavior

Macro is identically defined in lines 57 and 60. Macro re-definition is usually a compiler warning, although doesn't seem to trigger (in MSVC 2013) if the definition is identical in both cases.

Possible Solution

Remove duplicate line 57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant