Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MovingLeastSquaresOMP: Wrong Ptr/ConstPtr typedefs #2054

Closed
ibtaylor opened this issue Nov 6, 2017 · 2 comments · Fixed by #2055
Closed

MovingLeastSquaresOMP: Wrong Ptr/ConstPtr typedefs #2054

ibtaylor opened this issue Nov 6, 2017 · 2 comments · Fixed by #2055

Comments

@ibtaylor
Copy link
Contributor

ibtaylor commented Nov 6, 2017

pcl/surface/include/pcl/surface/mls.h

Lines 743 to 747 in 079cf24

class MovingLeastSquaresOMP: public MovingLeastSquares<PointInT, PointOutT>
{
public:
typedef boost::shared_ptr<MovingLeastSquares<PointInT, PointOutT> > Ptr;
typedef boost::shared_ptr<const MovingLeastSquares<PointInT, PointOutT> > ConstPtr;

@taketwo
Copy link
Member

taketwo commented Nov 6, 2017

This does look like a mistake. A patch is welcome.

@ibtaylor
Copy link
Contributor Author

ibtaylor commented Nov 6, 2017

K, I'll make a PR

@ibtaylor ibtaylor mentioned this issue Nov 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrect Ptr/ConstPtr typedefs in MovingLeastSquaresOMP ibtaylor/pcl
2 participants
@ibtaylor @taketwo