-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Tracis CI from GitHub Services to GitHub App #2531
Comments
On it |
I changed them to Apps, not sure if they work already.. |
Probably all is well. I’ll ping you again if needed. |
Ok, there's something: I don't see GitHub CI added to the checks section of the repo. Edit: It was also not triggered with Sergey's recent PR #2532. See https://travis-ci.org/PointCloudLibrary/pcl/pull_requests |
Seems to work now, except the doc job not sure if that should work @taketwo maybe you can have a look? Also, we have a 100 minute timeout :). |
Let me get everything to run green just to confirm and then we disable the old webhook to travis-ci.org and update the badge. Edit: Just confirmed the 1h40m timeout. It's still not enough to build everything and run the tests. |
Should I ask for a longer timeout? Do you have an example where it failed because of the timeout? |
Here Sergio tried with a single build/test job and it failed with a timeout. After this he split the task into two and they became shorter than 100 minutes It's hard to estimate how much more time we would need for the single job approach. Probably 30 minutes will be sufficient, but only empirical test can show. But anyway, if they give us longer timeout we will use less of their resources since now a lot of compilation is duplicated between our build and test tasks (despite the name, "test" actually means "build tests + test"). |
Thanks, I would propose to leave it slit and fix the failing tests first. One we are sure that compiling everything makes sense, we can still ask for more. |
FYI, I just learned Travis CI started rolling out Windows environments. It's not supporting C/C++ yet though. |
Did Anna tell you this? 😉 |
Reopening because of the issue with the docs job in #2538 . |
@jspricke GitHub Services are being phased out. We need to start using Travis CI through the GitHub Apps interface.
See more information here
https://developer.github.com/changes/2018-04-25-github-services-deprecation/
The text was updated successfully, but these errors were encountered: