Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Tracis CI from GitHub Services to GitHub App #2531

Closed
SergioRAgostinho opened this issue Oct 7, 2018 · 12 comments
Closed

Migrate Tracis CI from GitHub Services to GitHub App #2531

SergioRAgostinho opened this issue Oct 7, 2018 · 12 comments
Milestone

Comments

@SergioRAgostinho
Copy link
Member

@jspricke GitHub Services are being phased out. We need to start using Travis CI through the GitHub Apps interface.

See more information here
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

@jspricke
Copy link
Member

jspricke commented Oct 7, 2018

On it

@jspricke
Copy link
Member

jspricke commented Oct 7, 2018

I changed them to Apps, not sure if they work already..

@SergioRAgostinho
Copy link
Member Author

Probably all is well. I’ll ping you again if needed.

@SergioRAgostinho
Copy link
Member Author

SergioRAgostinho commented Oct 7, 2018

Ok, there's something: I don't see GitHub CI added to the checks section of the repo.

Edit: It was also not triggered with Sergey's recent PR #2532. See https://travis-ci.org/PointCloudLibrary/pcl/pull_requests

@jspricke
Copy link
Member

Seems to work now, except the doc job not sure if that should work @taketwo maybe you can have a look?

Also, we have a 100 minute timeout :).

@SergioRAgostinho
Copy link
Member Author

SergioRAgostinho commented Oct 10, 2018

Let me get everything to run green just to confirm and then we disable the old webhook to travis-ci.org and update the badge.

Edit: Just confirmed the 1h40m timeout. It's still not enough to build everything and run the tests.

@jspricke
Copy link
Member

Should I ask for a longer timeout? Do you have an example where it failed because of the timeout?

@taketwo
Copy link
Member

taketwo commented Oct 12, 2018

Here Sergio tried with a single build/test job and it failed with a timeout. After this he split the task into two and they became shorter than 100 minutes

It's hard to estimate how much more time we would need for the single job approach. Probably 30 minutes will be sufficient, but only empirical test can show. But anyway, if they give us longer timeout we will use less of their resources since now a lot of compilation is duplicated between our build and test tasks (despite the name, "test" actually means "build tests + test").

@jspricke
Copy link
Member

Thanks, I would propose to leave it slit and fix the failing tests first. One we are sure that compiling everything makes sense, we can still ask for more.

@SergioRAgostinho
Copy link
Member Author

FYI, I just learned Travis CI started rolling out Windows environments. It's not supporting C/C++ yet though.

@taketwo
Copy link
Member

taketwo commented Oct 12, 2018

Did Anna tell you this? 😉

@SergioRAgostinho
Copy link
Member Author

Reopening because of the issue with the docs job in #2538 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants