Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpha channel handling in PointCloudColorHandler #301

Closed
nizar-sallem opened this issue Oct 8, 2013 · 2 comments · Fixed by #306
Closed

Alpha channel handling in PointCloudColorHandler #301

nizar-sallem opened this issue Oct 8, 2013 · 2 comments · Fixed by #306

Comments

@nizar-sallem
Copy link
Contributor

Hi,

Seems that we don't handle the alpha channel in the PointCloudColorHandler.
After a bit of investigation it appears we only use the RGB data to build the scalars.
I would suggest that we create a specialization for the pcl::PointXYZRGBA at least where the alpha is handled correctly. Of course we would need to modify the default constructor of pcl::PointXYZRGBA accordingly so that every point is opaque to start with or else we would have to add an alpha capable color handler (my preference goes for this one as I think the PCD file are saved from kinect and so on with alpha set to 0 which would lead to black point clouds I am afraid but didn't experiment that yet).

What do you think ? @jspricke @rbrusu

@jspricke
Copy link
Member

+1 from me, @nizar-sallem did you have a look at the black cloud already? Also, you can upgrade an issue to a pull request using http://hub.github.com/. Would be great if you could use this instead of opening two bugs for the same thing. Thanks!

@nizar-sallem
Copy link
Contributor Author

Hi Jochen I did that and sent the pull request already, as it is referenced this one will be closed once the pull request is merged.
The black cloud is fixed in the pull request as well by setting a to 255 in the default PointXYZRGBA constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants