Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve method names in all classes of DataFrame-IO package #156

Open
olekscode opened this issue Oct 21, 2021 · 1 comment
Open

Improve method names in all classes of DataFrame-IO package #156

olekscode opened this issue Oct 21, 2021 · 1 comment

Comments

@olekscode
Copy link
Member

Some names are very bad.
For example, uniform and uniformDefaultValue are booleans so they should be called something like isUniform and isUniformDefaultValue (although I'm not sure what that second one means).

What is orient?

defaultLineEndConvention should be defaultNewLineCharacter or something like that

... etc., etc., etc.

@DARK-art108
Copy link

@olekscode can you provide more explanation on what we are trying to achieve I have read the above issue comment but not able to understand it clearly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants