Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix attribute-like text rendering "$lit$" #855

Merged
merged 2 commits into from
Apr 4, 2019
Merged

Fix attribute-like text rendering "$lit$" #855

merged 2 commits into from
Apr 4, 2019

Conversation

jridgewell
Copy link
Contributor

Also gives us a chance to use a faster check when looking for bound attributes, since we're already paying for the bytes.

Fixes #854, and includes the test from #854.

ruphin and others added 2 commits March 3, 2019 23:29
@ruphin
Add test for rendering attribute-like parts
1e08018
@jridgewell
Fix attribute-like text rendering "$lit$"
e293fb2 
Also gives us a chance to use a faster check when looking for bound attributes, since we're already paying for the bytes.

Fixes lit#854
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@jridgewell
Copy link
Contributor Author

/cc @ruphin, I included your test case commit in this. @googlebot needs your permission.

@ruphin
Copy link
Contributor

ruphin commented Mar 4, 2019

I grant permission.

@justinfagnani justinfagnani merged commit e3dccbe into lit:master Apr 4, 2019
@jridgewell jridgewell deleted the test_attribute-like_part branch April 4, 2019 22:54
neuronetio pushed a commit to neuronetio/lit-html that referenced this pull request Dec 2, 2019
@jridgewell @justinfagnani
Fix attribute-like text rendering "$lit$" (lit#855)
bd1b08d 
Also gives us a chance to use a faster check when looking for bound attributes, since we're already paying for the bytes.

Fixes lit#854
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinfagnani justinfagnani justinfagnani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jridgewell @googlebot @ruphin @justinfagnani