Fix style attribute bindings in IE #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Creative solution to the IE11 style problem. I like it :) |
justinfagnani
force-pushed
the
ie-attributes
branch
2 times, most recently
from
e7e5182 to
2aaf75c
Compare
|
@sorvell tests passing now, PTAL |
sorvell
approved these changes
Aug 24, 2018
src/lib/template-result.ts
Outdated
| @@ -55,6 +55,13 @@ export class TemplateResult { | |||
| // "...": no change. open === -1, close === -1 | |||
| isTextBinding = | |||
| (close > -1 || isTextBinding) && s.indexOf('<', close + 1) === -1; | |||
|
|
|||
| // IE does a bad. Work around it. | |||
There was a problem hiding this comment.
A better explanation would help =)
justinfagnani
force-pushed
the
ie-attributes
branch
from
2aaf75c to
830d7e6
Compare
justinfagnani
force-pushed
the
ie-attributes
branch
from
830d7e6 to
4c0b542
Compare
justinfagnani
changed the title
neuronetio
pushed a commit
to neuronetio/lit-html
that referenced
this pull request
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #450