Apply theme to API docs #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
Thanks! I notice you went back to the default theme, with the nav on the right side. Was that just easier to extend, or were there other things you wanted from the default theme? |
|
Er, I didn't notice I'd done it, sorry! I must have extended the wrong
typedoc theme. Will do another PR with minimal theme.
…On Fri, Dec 21, 2018 at 4:42 PM Arthur Evans ***@***.***> wrote:
Thanks! I notice you went back to the default theme, with the nav on the
right side. Was that just easier to extend, or were there other things you
wanted from the default theme?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#724 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AVLM4e6AOK1M8AuQRGh_vBDyg9Fc-SS2ks5u7YAEgaJpZM4ZfMoo>
.
|
|
@katejeffreys did you mean to close this PR, or are you going to update it? |
|
I did mean to update it. I spent some more time on it this morning but couldn't get the minimal theme to build with the main docs theme. @arthurevans Sorry I couldn't get this working. |
|
Going to merge this as-is and iterate. Thanks @katejeffreys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://20181221t150723-dot-polymer-lit-html.appspot.com/api/index.html