Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Improve text, fix typos in Getting Started #767

Merged
merged 3 commits into from
Jan 29, 2019
Merged

[docs] Improve text, fix typos in Getting Started #767

merged 3 commits into from
Jan 29, 2019

Conversation

straversi
Copy link
Contributor

A couple typo fixes and phrase rewords.

arthurevans
arthurevans approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@arthurevans arthurevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

docs/_guide/01-getting-started.md Outdated
@@ -65,7 +65,7 @@ import {html, render} from 'lit-html';
lit-html has two main APIs:

* The `html` template tag used to write templates
* The `render()` function used to render a template to a DOM container.
* The `render()` function used to render a template to a DOM container
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to our style guide, these should both have periods.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

Arthur Evans and others added 2 commits January 29, 2019 15:49
@straversi straversi force-pushed the getting-started-text branch from aa9b222 to 2e52a6a Compare January 29, 2019 23:50
@googlebot
Copy link

CLAs look good, thanks!

@arthurevans
Copy link
Contributor

Victory! 👍

@arthurevans arthurevans merged commit 9916f2f into master Jan 29, 2019
@justinfagnani justinfagnani deleted the getting-started-text branch February 9, 2019 23:38
neuronetio pushed a commit to neuronetio/lit-html that referenced this pull request Dec 2, 2019
@straversi
[docs] Improve text, fix typos in Getting Started (lit#767)
5cb2359 
* [docs] Improve text, fix typos in Getting Started

* Update docs/_guide/01-getting-started.md

Co-Authored-By: straversi <[email protected]>

* Update docs/_guide/01-getting-started.md

Co-Authored-By: straversi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthurevans arthurevans arthurevans approved these changes

@justinfagnani justinfagnani Awaiting requested review from justinfagnani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@straversi @googlebot @arthurevans