-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Improved section on registering elements #1479
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
This is the implementation of #1456 -- basically, I had my questions answered and rewrote the relevant section. Feel free to use it, change it, bit it, whatever :D |
(I signed the CLA BTW!) |
CLAs look good, thanks! |
As I wrote on the original ticket:
Maybe this PR could be improved by somebody at Google who could cover this? |
- `created` callback local DOM initialized (This means that **local DOM** | ||
- children are created, their property values are set as specified in the | ||
- template, and `ready()` has been called on them) `ready` callback | ||
- [`factoryImpl` callback](#custom-constructor) `attached` callback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting looks messed up on this bulleted list.
…ed following Arthur's requests
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I am confused... I had already signed the CLA; I re-did it just now, and yet it's saying that it cannot verify my consent? |
CLAs look good, thanks! |
Something strange happened, but it seems to be all good now. |
CLA bot is crazy bot |
LGTM, thanks. I'll do a little massaging after I merge this. |
Hi, Fantastic! Merc.
|
Closing in favor of #1506, which includes these changes and more. (Feel free to review over there.) |
Hi,
And... here it is. I tried to make the language less "chatty" and did my best to explain exactly what goes on when elements are created.
I also improved it as much as possible. I really think it's a much better section now.
Thank you!
Merc.