This repository has been archived by the owner on May 29, 2019. It is now read-only.
3.0 polymer.json - add new options & restructure TOC #2498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you want a review on this, or are you going to do another update first? |
|
Probably needs another update first. Thanks
…On Mon, Mar 19, 2018 at 10:43 AM Arthur Evans ***@***.***> wrote:
Do you want a review on this, or are you going to do another update first?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2498 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AVLM4af97mdK4Jblb-uitihSmTwTfPrjks5tf-5FgaJpZM4SssIs>
.
|
ghost
requested a review
from 
ghost
changed the title
|
Ready for review @arthurevans |
arthurevans
suggested changes
Apr 12, 2018
app/3.0/docs/tools/polymer-json.md
Outdated
| ### entrypoint | ||
| Optional, Defaults to `index.html`<br> | ||
| Type: `String` | ||
| **Quick reference** {#quickreference} |
There was a problem hiding this comment.
This should be a header, not just bolded.
app/3.0/docs/tools/polymer-json.md
Outdated
| shell file specified in the shell property. It should be as small as possible since it’s served for | ||
| all routes. All paths in the entrypoint should be absolute, because this file is served from many | ||
| different URLs. | ||
| * [`root`](#root): Specify the path to the root project folder |
There was a problem hiding this comment.
End bullets with period.
Minor nit, but other lists like this in the docs we have Keyword. Description. Rather than Keyword: Description.
app/3.0/docs/tools/polymer-json.md
Outdated
| Creating a `polymer.json` in your project directory allows you to store information about your | ||
| project structure and desired build configuration(s). It is used by the [Polymer CLI](polymer-cli) | ||
| as a way to understand the structure of your application. | ||
| Create a `polymer.json` file in your root project folder to configure the behavior of [Polymer CLI](polymer-cli) tools for your Polymer project. See the [Polymer 3.0 Sample App](https://github.com/PolymerLabs/start-polymer3/blob/master/polymer.json) for a working example. |
There was a problem hiding this comment.
root => top-level maybe?
Root has so many meanings (there's a project root in the polymer.json which may not be the same as the folder that polymer.json is in, server root, filesystem root, etc.) that it might be good not to reuse it here.
added 2 commits
April 12, 2018 13:55
|
Thanks @arthurevans. Fixed things and redeployed it. |
arthurevans
approved these changes
Apr 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://polymer-json-dot-polymer-project.appspot.com