This repository has been archived by the owner on May 29, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurevans
reviewed
Apr 27, 2018
app/3.0/docs/tools/tests.md
Outdated
This guide shows you the basics of using Polymer CLI to run unit tests, and | ||
how to accomplish various tasks and scenarios using the Web Component Tester | ||
library (the underlying library that powers Polymer CLI's testing tools). | ||
|
||
**Update your tools for 2.0.** For testing with 2.0, make sure you have the latest | ||
version of the Polymer CLI. | ||
**Update your tools for 3.0.** For testing with 3.0, make sure you have the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be @next
I think, or leave off the @version
if it's for next stable.
When we publish, we should probably have the CLI released as stable. Double check with tools team, but I think that would be a prerequisite.
arthurevans
reviewed
Apr 27, 2018
app/3.0/docs/tools/tests.md
Outdated
|
||
To run a set of test suites: | ||
|
||
1. Create an HTML file with a script that calls the `loadSuites` method. `loadSuites` takes as an argument an array of strings, where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This formatting is weird. It makes no difference, but it's weird.
arthurevans
approved these changes
Apr 27, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comments, otherwise LGTM.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2524