Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Custom elements updates, first cut. #2540

Merged
merged 3 commits into from
Apr 30, 2018
Merged

Custom elements updates, first cut. #2540

merged 3 commits into from
Apr 30, 2018

Conversation

arthurevans
Copy link

No description provided.


```
my-element:not(:defined) {
background-color: blue;
}
```

**`:defined` is not supported by the Custom Elements polyfill.** See the [documentation on styling](style-shadow-dom#style-undefined-elements) for a workaround.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link doesn't seem to exist anymore?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put it back in d9d4ff6

@arthurevans
Copy link
Author

@arthurevans arthurevans requested a review from a user April 27, 2018 20:29
// Create a class that extends HTMLElement (directly or indirectly)
class MyElement extends HTMLElement { … };
```js
import {PolymerElement} from '@polymer/polymer/polymer-element.js`;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backtick should be single quote

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, ty.

```
```js
// Import PolymerElement class
import {PolymerElement} from '@polymer/polymer/polymer-element.js`;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backtick should be single quote

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a little confused by what a legacy element is - do we have a definition of that?

@arthurevans arthurevans merged commit b4f4ac1 into master Apr 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants