-
Notifications
You must be signed in to change notification settings - Fork 1
Refactoring Week
Poobslag edited this page Nov 16, 2023
·
88 revisions
Refactoring week occurs every two months. It's good for code to have time to rest, where we can clean up technical debt.
- Replace connect calls like
PlayerData.connect("world_index_changed", Callable(self, "_on_player_data_world_index_changed"))withPlayerData.world_index_changed.connect(_on_player_data_world_index_changed). - Centralize world info into a config file: see #244
- Random demos like 'BackgroundDemo' shouldn't play music, unless they have specific code to do so. Currently, MusicPlayer is a singleton and loads in every scene, playing music.