Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"There are no matching events for this query" message for a slow-loading funnel is confusing #5584

Closed
1 of 2 tasks
dknowles-vsk opened this issue Aug 13, 2021 · 4 comments · Fixed by #5607
Closed
1 of 2 tasks
Assignees
Labels
bug Something isn't working right

Comments

@dknowles-vsk
Copy link

dknowles-vsk commented Aug 13, 2021

Bug description

When a funnel is taking a long time to load (1+ minute), it shows the following contents:

  1. A spinner
  2. A screen that says "There are no matching events for this query"
  3. A screen that says "Looks like things are a little slow"

Screen Shot 2021-08-16 at 1 56 13 PM
Screen Shot 2021-08-16 at 2 12 22 PM

Since Step #2 can hang around a long time, it's caused confusion for many of our internal users.

Expected behavior

Don't show step #2.

How to reproduce

  1. Create an extremely slow query in a funnel (1+ minutes to load)
  2. Wait & watch

Environment

  • PostHog Cloud
  • self-hosted PostHog

Additional context

Our deployment has recently seen its resources upgraded; this may not appear anymore if the deployment is sufficiently quick.

Thank you for your bug report – we love squashing them!

@dknowles-vsk dknowles-vsk added the bug Something isn't working right label Aug 13, 2021
@dknowles-vsk dknowles-vsk changed the title "Nothing matches this filter" message for a slow-loading funnel is confusing "There are no matching events for this query" message for a slow-loading funnel is confusing Aug 16, 2021
@macobo
Copy link
Contributor

macobo commented Aug 19, 2021

cc @clarkus and @paolodamico :)

@clarkus
Copy link
Contributor

clarkus commented Aug 19, 2021

  • Let's move towards a skeleton loader state for this insight chart type
  • I think the flashing of the "no matching events" state is probably a bug here. Are we referencing the wrong empty state or is something else triggering this state prematurely?
  • When things are slow, should we show an additional empty state, or just append messaging to the current empty state. This problem is actually broader than funnels, so it might be better to solve it in a more centralized way.

@paolodamico
Copy link
Contributor

I actually think that our current "things are going slow" loader is pretty on point. The skeleton loader would make sense if it was the regular loading state, but this is shown when things are taking longer than usual. It's definitely a bug that we're showing the empty state while things are loading and then showing the things are slow view. @alexkim205 think it's related to what you're working on so maybe you can pick it up?

@alexkim205
Copy link
Contributor

The no matching events flashing is definitely a bug that was introduced by nested state checking in our funnels components. #5607 should address the problems raised in this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants