Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When saving an insight I get a warning asking if I should discard it #9392

Closed
1 of 3 tasks
marcushyett-ph opened this issue Apr 12, 2022 · 5 comments · Fixed by #9397
Closed
1 of 3 tasks

When saving an insight I get a warning asking if I should discard it #9392

marcushyett-ph opened this issue Apr 12, 2022 · 5 comments · Fixed by #9397
Assignees
Labels
bug Something isn't working right

Comments

@marcushyett-ph
Copy link
Contributor

Bug description

image

How to reproduce

  1. Create a new insight
  2. Click Save
  3. You see the warning above asking if you'd like to discard it

Environment

  • PostHog Cloud
  • self-hosted PostHog (ClickHouse-based), version/commit: please provide
  • self-hosted PostHog (Postgres-based, legacy), version/commit: please provide

Additional context

Thank you for your bug report – we love squashing them!

@Twixes
Copy link
Member

Twixes commented Apr 12, 2022

I haven't been able to reproduce this – seems like very much an edge case. Do you know what exact steps you took that led to this?

@marcushyett-ph
Copy link
Contributor Author

marcushyett-ph commented Apr 12, 2022

Good shout - it's not a small edge-case though - adding a filter seems to trigger it, this is a video of me starting from a completely fresh insight.

Screen.Recording.2022-04-12.at.15.20.44.mov

@Twixes
Copy link
Member

Twixes commented Apr 12, 2022

Ohh, I see, this only happens with the and-or-filtering feature flag. Filters are handled slightly different there.

@neilkakkar
Copy link
Contributor

@Twixes we released and-or for everyone, you're not seeing it on your account? 🤔 .

@Twixes
Copy link
Member

Twixes commented Apr 12, 2022

I had it off locally. @neilkakkar BTW it's not in PERSISTED_FEATURE_FLAGS so it's not released for self-hosted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants