Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-implement minimal length for jwt-secret #3607

Closed
wolfgangwalther opened this issue Jun 17, 2024 · 0 comments · Fixed by #3628
Closed

Re-implement minimal length for jwt-secret #3607

wolfgangwalther opened this issue Jun 17, 2024 · 0 comments · Fixed by #3628

Comments

@wolfgangwalther
Copy link
Member

wolfgangwalther commented Jun 17, 2024 •
edited
Loading

It seems that after the change to jose-jwt in 465170c, we don't require a minimum of 32 characters for jwt-secret anymore.

The question is: Should we keep it like that or re-implement that limit ourselves? If we re-implement it, we can surely do #1840 (comment).

I tend to say the limit is useful and we should implement it again with a proper error message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add message when JWT secret is less than 32 characters long laurenceisla/postgrest
1 participant
@wolfgangwalther