From d148171f90c1e782698ea5467754a492ffda54b5 Mon Sep 17 00:00:00 2001 From: zzstoatzz Date: Mon, 16 Dec 2024 19:08:43 -0800 Subject: [PATCH] add namespace --- .../prefect-redis/prefect_redis/client.py | 16 ++++++++++++---- .../prefect-redis/tests/test_client.py | 6 +++--- 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/src/integrations/prefect-redis/prefect_redis/client.py b/src/integrations/prefect-redis/prefect_redis/client.py index 1063a5541513..51f654c15600 100644 --- a/src/integrations/prefect-redis/prefect_redis/client.py +++ b/src/integrations/prefect-redis/prefect_redis/client.py @@ -12,8 +12,14 @@ ) -class RedisSettings(PrefectBaseSettings): - model_config = _build_settings_config(("redis",), frozen=True) +class RedisMessagingSettings(PrefectBaseSettings): + model_config = _build_settings_config( + ( + "redis", + "messaging", + ), + frozen=True, + ) host: str = Field(default="localhost") port: int = Field(default=6379) @@ -98,7 +104,7 @@ def get_async_redis_client( Returns: Redis: a Redis client """ - settings = RedisSettings() + settings = RedisMessagingSettings() return Redis( host=host or settings.host, @@ -114,7 +120,9 @@ def get_async_redis_client( @cached -def async_redis_from_settings(settings: RedisSettings, **options: Any) -> Redis: +def async_redis_from_settings( + settings: RedisMessagingSettings, **options: Any +) -> Redis: options = { "retry_on_timeout": True, "decode_responses": True, diff --git a/src/integrations/prefect-redis/tests/test_client.py b/src/integrations/prefect-redis/tests/test_client.py index 6a3cfef97a88..11d19c01d90d 100644 --- a/src/integrations/prefect-redis/tests/test_client.py +++ b/src/integrations/prefect-redis/tests/test_client.py @@ -1,7 +1,7 @@ from unittest.mock import MagicMock, patch from prefect_redis.client import ( - RedisSettings, + RedisMessagingSettings, async_redis_from_settings, close_all_cached_connections, get_async_redis_client, @@ -11,7 +11,7 @@ def test_redis_settings_defaults(): """Test that RedisSettings has expected defaults""" - settings = RedisSettings() + settings = RedisMessagingSettings() assert settings.host == "localhost" assert settings.port == 6379 assert settings.db == 0 @@ -50,7 +50,7 @@ async def test_get_async_redis_client_custom_params(): async def test_async_redis_from_settings(): """Test creating Redis client from settings object""" - settings = RedisSettings( + settings = RedisMessagingSettings( host="settings.host", port=6381, username="settings_user",