Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Add support for ingresses #196

Closed
zanieb opened this issue Feb 25, 2021 · 0 comments · Fixed by #229
Closed

Helm: Add support for ingresses #196

zanieb opened this issue Feb 25, 2021 · 0 comments · Fixed by #229

Comments

@zanieb
Copy link
Contributor

zanieb commented Feb 25, 2021

Yeah, I think having an ingress shouldn't be on by default (or required), but supporting an opt-in option which requires some user configuration makes sense to me. This is what JupyterHub does as well, and it seems to work well. https://zero-to-jupyterhub.readthedocs.io/en/latest/administrator/advanced.html#ingress, https://github.com/jupyterhub/zero-to-jupyterhub-k8s/blob/master/jupyterhub/templates/ingress.yaml.

Originally posted by @jcrist in #123 (comment)

Also see an example at https://devspace.sh/component-chart/docs/configuration/ingress

May be blocked by UI changes -- will update this note once I have more infomration.

@zanieb zanieb linked a pull request Mar 25, 2021 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant