Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUICK RUN cannot take newer Default Parameter updated from UI #64

Closed
xyliutw opened this issue Sep 1, 2020 · 2 comments · Fixed by #65
Closed

QUICK RUN cannot take newer Default Parameter updated from UI #64

xyliutw opened this issue Sep 1, 2020 · 2 comments · Fixed by #65

Comments

@xyliutw
Copy link

xyliutw commented Sep 1, 2020

Description

The QUICK RUN button will take default Parameter which is given when registered, but it still takes this default Parameter no matter how I modify it on UI later (settings->Parameters->Default Parameters).

Expected Behavior

"QUICK RUN" should take the parameter after user update it on UI. Like the code below, when I register and run this flow, it will return 3 (2+1), but when I modify the parameter from 2 to 50, it still return 3.

Reproduction

from prefect import task, Flow, Parameter
import prefect

logger = prefect.utilities.logging.get_logger()
@task
def print_plus_one(x):
    print(x + 1)
    logger.warning(x+1)

with Flow('Parameterized Flow') as flow:
    x = Parameter('x', default = 2)
    print_plus_one(x=x)

flow.register(project_name="Test Project")

Environment

Prefect version: 0.13.2

@joshmeek
Copy link
Contributor

joshmeek commented Sep 1, 2020

Hi @xyliutw I have reproduced your error and submitted a fix in #65. Thanks for reporting 🙂

@xyliutw
Copy link
Author

xyliutw commented Sep 1, 2020 via email

@cicdw cicdw closed this as completed in #65 Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants