Skip to content
This repository was archived by the owner on Feb 14, 2025. It is now read-only.

Fix types #33

Open
FrameMuse opened this issue Apr 1, 2022 · 0 comments
Open

Fix types #33

FrameMuse opened this issue Apr 1, 2022 · 0 comments

Comments

@FrameMuse
Copy link

FrameMuse commented Apr 1, 2022

Problem

There are several problems with typings

Somewhere you put any like in this example

* @property {GaOptions|any} [gaOptions]

Niether put any types like here
send = (fieldObject) => {

So then it becomes any anyway.
This is the opposite of what typings are for.

Solution

In my opinion, it's better to rewrite the script in ts, so it's easier to maintain types, or eventually put right types everywhere

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant