Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor reminder app #912

Open
7 tasks
RomanovaPrime opened this issue Dec 12, 2024 · 1 comment
Open
7 tasks

Refactor reminder app #912

RomanovaPrime opened this issue Dec 12, 2024 · 1 comment
Assignees

Comments

@RomanovaPrime
Copy link
Contributor

As a developper I want to have testable and consistent with other examples reminder app.

ACs:

  • Refactor the business layer
    • Clear out bloc bodies. Move the logic in state mappers, where possible
    • Add services to extract data manipulations and reduse usage of bloc extensions
    • Add tests for newly created and updated classes
  • Refactor the UI layer
    • Replace all possible custom widgets with standart components from widget_toolkit
    • Update golden tests
@RomanovaPrime RomanovaPrime converted this from a draft issue Dec 12, 2024
@nikolay-vasilev-prime nikolay-vasilev-prime moved this to In Progress in rx_bloc_cli Feb 11, 2025
@nikolay-vasilev-prime nikolay-vasilev-prime self-assigned this Feb 11, 2025
@nikolay-vasilev-prime
Copy link
Contributor

  • Reminder List Scroll View need refactoring, because too many bussines logic is in the UI layer.
  • Add Reminder Dialog needs refactoring
  • Reminder manage bloc needs refactoring
  • Harcoded strings need to be extracted in the l10n
  • Dashboard page needs refactoring
  • Dashboard bloc can be optimized
  • App run configurations are not recognized by Android Studio
  • Widget toolkit can be used instead custom views. For example Snackbar can be replaced with bottomsheet dialog.
  • Tests will need to be optimized to work with the new improvements.

Estimate: 8-10 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants