Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Allow cloning of circular structures. #1345

Merged
merged 1 commit into from
Mar 13, 2018
Merged

Core: Allow cloning of circular structures. #1345

merged 1 commit into from
Mar 13, 2018

Conversation

Golmote
Copy link
Contributor

@Golmote Golmote commented Mar 11, 2018

With this, it will be possible to remove most of the cloning occurrences in language definitions (since it was used mainly to prevent infinite recursion when extending).

It should even be possible to fix #1342, unexpectedly.

mAAdhaTTah
mAAdhaTTah approved these changes Mar 11, 2018
View reviewed changes
Copy link
Member

@mAAdhaTTah mAAdhaTTah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It may help the diff if you early return-ed instead of if / else-'ing, but that's optional.

@Golmote
Copy link
Contributor Author

Golmote commented Mar 12, 2018 •
edited
Loading

@mAAdhaTTah You're right! That's much more clear now. Thanks for reviewing!

@Golmote Golmote merged commit f90d555 into PrismJS:gh-pages Mar 13, 2018
@Golmote Golmote deleted the clone-circular branch March 13, 2018 07:12
@Golmote Golmote mentioned this pull request Mar 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mAAdhaTTah mAAdhaTTah mAAdhaTTah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Golmote @mAAdhaTTah