Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token operator should not have a background #1347

Closed
paladox opened this issue Mar 11, 2018 · 8 comments
Closed

Token operator should not have a background #1347

paladox opened this issue Mar 11, 2018 · 8 comments

Comments

@paladox
Copy link
Contributor

paladox commented Mar 11, 2018

Like the other tokens, token operator should not have a background, make things look a little wierd.

screen shot 2018-03-11 at 22 48 44

See ^^

@Golmote
Copy link
Contributor

Golmote commented Mar 11, 2018

Since you decided to change the background color of the theme, you should probably change or remove the background color of the operators, indeed.

This is ok as part of the original theme, tho.

@Golmote Golmote closed this as completed Mar 11, 2018
@paladox
Copy link
Contributor Author

paladox commented Mar 11, 2018

I didn't change the colour of it though :)

@Golmote
Copy link
Contributor

Golmote commented Mar 11, 2018

The background color of the code block, I meant. This greenish background isn't the original background of the default theme is it?

@paladox
Copy link
Contributor Author

paladox commented Mar 11, 2018

Ah i see, yeh.

@Golmote
Copy link
Contributor

Golmote commented Mar 11, 2018

So I consider you did some customization, and so you might also need to customize more to make it look less weird.

@paladox
Copy link
Contributor Author

paladox commented Mar 11, 2018

Yeh, we are using the highlight function so it dosen't implement the language- class. (well not really we are as i am trying to implement this in gerrit https://gerrit-review.googlesource.com/c/gerrit/+/160034/ but need #1325 to be resolved :))

@paladox
Copy link
Contributor Author

paladox commented Mar 11, 2018

@Golmote im wondering if we could remove it offically from the token or is it needed?

@Golmote
Copy link
Contributor

Golmote commented Mar 11, 2018

IMO no we should not. It looks good on the theme and the author did it like this, I won't discuss it.
This is theme customization, and theme customization should be in your own CSS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants