-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token operator should not have a background #1347
Comments
Since you decided to change the background color of the theme, you should probably change or remove the background color of the operators, indeed. This is ok as part of the original theme, tho. |
I didn't change the colour of it though :) |
The background color of the code block, I meant. This greenish background isn't the original background of the default theme is it? |
Ah i see, yeh. |
So I consider you did some customization, and so you might also need to customize more to make it look less weird. |
Yeh, we are using the highlight function so it dosen't implement the language- class. (well not really we are as i am trying to implement this in gerrit https://gerrit-review.googlesource.com/c/gerrit/+/160034/ but need #1325 to be resolved :)) |
@Golmote im wondering if we could remove it offically from the token or is it needed? |
IMO no we should not. It looks good on the theme and the author did it like this, I won't discuss it. |
Like the other tokens, token operator should not have a background, make things look a little wierd.
See ^^
The text was updated successfully, but these errors were encountered: