Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multiline strings to clojure, lisp style #2061

Merged
merged 3 commits into from
Sep 25, 2019
Merged

Add multiline strings to clojure, lisp style #2061

merged 3 commits into from
Sep 25, 2019

Conversation

sooheon
Copy link
Contributor

@sooheon sooheon commented Sep 24, 2019

The following should be legal in clojure:

"multiline
string"

@RunDevelopment
Copy link
Member

Thank you for contributing @sooheon!

I'll review in a sec, but before that: The build fails because components/prism-clojure.min.js isn't up to date. If I had to guess I'd say you rebuilt Prism and then made another change to prism-/clojure.js (happens to me all the time).
So please rebuild Prism again, so the build passes.

RunDevelopment
RunDevelopment approved these changes Sep 24, 2019
View reviewed changes
Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the failed test, this is ready to merge.

@sooheon
Copy link
Contributor Author

sooheon commented Sep 25, 2019 •
edited
Loading

Thanks for the tip, that indeed was the problem. Rebuilt and pushed!

@RunDevelopment RunDevelopment merged commit 8ea685b into PrismJS:master Sep 25, 2019
@RunDevelopment
Copy link
Member

Thank you for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RunDevelopment RunDevelopment RunDevelopment approved these changes

Assignees
No one assigned
Labels
enhancement language-definitions needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sooheon @RunDevelopment