Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Prism as a dependency in the other languages #642

Closed
XVincentX opened this issue Jul 21, 2015 · 8 comments
Closed

Require Prism as a dependency in the other languages #642

XVincentX opened this issue Jul 21, 2015 · 8 comments

Comments

@XVincentX
Copy link

Actually, Prism languages definition are just assuming that Prism is already loaded. This does not let me load language components on demand in a modular way.

@Golmote
Copy link
Contributor

Golmote commented Jul 21, 2015

True.

@XVincentX
Copy link
Author

@Golmote Cool, can we do something for that?

@mAAdhaTTah
Copy link
Member

Related: #456

@Golmote
Copy link
Contributor

Golmote commented Jul 24, 2015

Oh thanks! I was looking for this issue and couldn't find it.

@XVincentX Yes, we can do something about that, but it's not a small change. See #456 (comment).
I'd love to see Prism going asynchronous but this will require quite some work!

@apfelbox
Copy link
Contributor

UMD would be really nice, but that would be quite a massive rewrite with touching nearly every file in the repository.

@mAAdhaTTah
Copy link
Member

@Golmote Yeah, I have it bookmarked because I'd like to tackle it at some point, but I haven't had the time nor the approach yet. @apfelbox is probably right, that asynchronously loading Prism's languages would probably be a major undertaking.

@breezewish
Copy link

+1 for this feature. in fact you only need to add something like var prism = require('./prism-core.js') in each file

@mAAdhaTTah
Copy link
Member

This should be resolved as part of #1359.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants