Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend / replace "show language" to be more generic #914

Closed
lukasoppermann opened this issue Mar 20, 2016 · 2 comments
Closed

Extend / replace "show language" to be more generic #914

lukasoppermann opened this issue Mar 20, 2016 · 2 comments

Comments

@lukasoppermann
Copy link
Contributor

As discussed in #910 it would be helpful if the show language plugin would be replaced by a more generic version that can add different custom labels to a prism instance.

Some features could be:

  • add multiple custom labels
  • auto-add language (if desired)
  • add a div to collect all labels (could be used as a bar on top or bottom, but could also be ignored, so that individual items can be styled, whatever a user wants)
  • if something like the config from Option to default to line-number for all code blocks #912 should be implemented, this plugin could use a config option to receive all items it should grab

There could be some overlap with the toolbar plugin from #891
The question is, if it would make sense to combine it with the toolbar or if they are to different in the idea. I think we should still try to keep it as small and simple as possible.

@mAAdhaTTah
Copy link
Member

I think the main difference between the show-language plugin & the toolbar plugin is the styles, honestly. I do know, for now, they don't play well together, so perhaps one should supersede the other.

@mAAdhaTTah
Copy link
Member

These have been combined now, so this is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants