Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong slot layout for minecraft:dispenser pre 1.14 #84

Open
IceTank opened this issue Nov 4, 2022 · 1 comment
Open

Wrong slot layout for minecraft:dispenser pre 1.14 #84

IceTank opened this issue Nov 4, 2022 · 1 comment

Comments

@IceTank
Copy link
Contributor

IceTank commented Nov 4, 2022

The window type minecraft:dispenser for versions pre 1.14 is wrong. The current layout is

prismarine-windows/index.js

Line 46 in 3d4514a

'minecraft:dispenser': { type: 'minecraft:dispenser', inventory: { start: 7 * 9, end: 7 * 9 + 35 }, slots: 7 * 9 + 36, craft: -1, requireConfirmation: true },
but as described here https://wiki.vg/index.php?title=Inventory&oldid=14093#Dispenser the layout should be different. This also causes window.items() in mineflayer with dispenser windows to fail.
@IceTank
Copy link
Contributor Author

IceTank commented Dec 26, 2022

Should be fixed with #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@IceTank