Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add Japanese Localization from Transifex #276

Closed
joshandrews opened this issue Mar 16, 2019 · 5 comments
Closed

Request to add Japanese Localization from Transifex #276

joshandrews opened this issue Mar 16, 2019 · 5 comments

Comments

@joshandrews
Copy link

We have added Japanese localization on Transifex and are requesting that it gets merged in.

@yuryleb
Copy link
Contributor

yuryleb commented Mar 16, 2019

Thanks for contribution!

Just one question: most variables have no whitespaces between translated text but there are several cases with them (see phrase block):

        "modes": {
            "ferry": {
                "default": "フェリーに乗る",
                "name": "{way_name}のフェリーに乗る",
                "destination": "{destination}に向けてフェリーに乗る"
            }
        },
        "phrase": {
            "two linked by distance": "{instruction_one} その先 {distance}で{instruction_two}",
            "two linked": "{instruction_one} その先 {instruction_two}",
            "one in distance": "{distance}先、{instruction_one}",
            "name and ref": "{name}({ref})",
            "exit with number": "{exit}出口です"
        },
        "arrive": {
            "default": {
                "default": "{nth}目の目的地に到着しました",
                "upcoming": "まもなく{nth}目の目的地に到着します",
                "short": "目的地に到着しました",
                "short-upcoming": "まもなく目的地に到着します",
                "named": "{waypoint_name}に到着しました"
            },

Is it a mistake/misprint or not?

@yuryleb
Copy link
Contributor

yuryleb commented Mar 16, 2019

Also Chinese translation uses special bracket chars with intervals included:

        "phrase": {
            "two linked by distance": "{instruction_one},{distance}后{instruction_two}",
            "two linked": "{instruction_one},随后{instruction_two}",
            "one in distance": "{distance}后{instruction_one}",
            "name and ref": "{name}({ref})",
            "exit with number": "出口{exit}"
        },

Maybe Japanese one should use the same/similar brackets too?

@joshandrews
Copy link
Author

Thanks for the look through @yuryleb !

  1. For locations where white spaces exist the idea was to separate the two instructions instructions. Before その先 is first instruction, after その先 is second instruction. This is considered normal in Japanese.

  2. Both of these characters, and (, can be used in Japanese, however in this case, "name and ref": "{name}({ref})", it makes more sense in Japanese to not include the space.

Let me know if you have any additional questions.

@yuryleb yuryleb mentioned this issue Mar 19, 2019
3 tasks
@yuryleb
Copy link
Contributor

yuryleb commented Mar 19, 2019

Ok, please review new PR with your translation from Transifex.

BTW maybe you could also provide localization for OSRM frontend with a similar way?

@1ec5
Copy link
Member

1ec5 commented Mar 26, 2019

Fixed in #277.

@1ec5 1ec5 closed this as completed Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants