Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Update base Docker image and lock version #1351

Closed
madsboddum opened this issue Aug 13, 2023 · 0 comments · Fixed by #1357
Closed

[Misc] Update base Docker image and lock version #1351

madsboddum opened this issue Aug 13, 2023 · 0 comments · Fixed by #1357
Assignees
Labels
[Engine] Database IMPROVEMENT Enhancement of an existing feature

Comments

@madsboddum
Copy link
Member

madsboddum commented Aug 13, 2023

The current Dockerfile starts like this:

FROM debian:stretch-slim
...

debian:stretch-slim is being updated outside of our control, meaning our builds can change without us really knowing about it.
It would be better to select a tag that never changes after being published, such as stretch-20220622-slim.

While we're at it, updating to a newer version would be good.

Maybe configure Dependabot to do this automatically in the future.

To ensure it works and keeps working, create an automated test that starts a Docker container using the Dockerfile.
There are other benefits to doing this, as we generally can trust changesets more.

@madsboddum madsboddum added the IMPROVEMENT Enhancement of an existing feature label Aug 13, 2023
@madsboddum madsboddum changed the title [Misc] Lock base Docker image [Misc] Update and lock base Docker image Aug 13, 2023
@madsboddum madsboddum changed the title [Misc] Update and lock base Docker image [Misc] Automatic updates of base Docker image Aug 13, 2023
@madsboddum madsboddum changed the title [Misc] Automatic updates of base Docker image [Misc] Update base Docker image Aug 19, 2023
@madsboddum madsboddum changed the title [Misc] Update base Docker image [Misc] Update base Docker image and lock version Aug 19, 2023
@madsboddum madsboddum self-assigned this Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Engine] Database IMPROVEMENT Enhancement of an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants