From 283fcc8d21bb0714660c5cf34b99b4aaf1ddf552 Mon Sep 17 00:00:00 2001 From: Ziggy Date: Fri, 7 Jun 2024 21:36:30 +0200 Subject: [PATCH] Fixed a bug with quest rewards, where completing tasks that don't grant XP granted +0 unknown XP --- .../holocore/services/gameplay/player/quest/QuestService.kt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/projectswg/holocore/services/gameplay/player/quest/QuestService.kt b/src/main/java/com/projectswg/holocore/services/gameplay/player/quest/QuestService.kt index dd3b8406f..52bfeb55f 100644 --- a/src/main/java/com/projectswg/holocore/services/gameplay/player/quest/QuestService.kt +++ b/src/main/java/com/projectswg/holocore/services/gameplay/player/quest/QuestService.kt @@ -518,8 +518,9 @@ class QuestService(private val destroyMultiAndLootDie: Die = RandomDie(), privat private fun grantXPReward(player: Player, currentTask: QuestTaskInfo) { val experienceType = currentTask.experienceType - if (experienceType != null) { - ExperienceIntent(player.creatureObject, experienceType, currentTask.experienceAmount).broadcast() + val experienceAmount = currentTask.experienceAmount + if (!experienceType.isNullOrBlank() && experienceAmount > 0) { + ExperienceIntent(player.creatureObject, experienceType, experienceAmount).broadcast() } }