Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email Domains may lead to Data Leak #22

Closed
Akshu-on-github opened this issue Oct 13, 2022 · 6 comments · Fixed by #24
Closed

Email Domains may lead to Data Leak #22

Akshu-on-github opened this issue Oct 13, 2022 · 6 comments · Fixed by #24
Assignees
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed

Comments

@Akshu-on-github
Copy link
Contributor

Context

If an email domain is chosen at random, there is a chance that a real person would get a email with potentially sensitive info when a developer is testing. Even if a certain domain is not used now, there is no guarantee that it will remain unused in the future.

This problem can be circumvented using the @example domain that is reserved for research and testing purposes

What I'd suggest

Delete the list of email domains under the assets folder and have a static value for the email domain
Alternatively, store random email usernames in the text file and append the @example domain ([email protected])

@aayushi-droid
Copy link
Member

I agree with you.

@codeperfectplus
Copy link
Member

Thanks, @Akshu-on-github @aayushi-droid for pointing out the issue. would you like to make the suggested change?

@codeperfectplus codeperfectplus added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed labels Oct 13, 2022
@Akshu-on-github
Copy link
Contributor Author

Yes please! Which method should I implement?

@codeperfectplus
Copy link
Member

codeperfectplus commented Oct 13, 2022

Change the email domain to @example.com as suggested by you and keep the username as it also deletes the email_domains.txt file.

@codeperfectplus
Copy link
Member

@Akshu-on-github are you working on the issue?

@Akshu-on-github
Copy link
Contributor Author

@codeperfectplus - yes, I am!

@aayushi-droid aayushi-droid linked a pull request Oct 17, 2022 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants