Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node in Nodes collection do not report a MIXED state, only IDLE or ALLOCATED #317

Closed
tazend opened this issue Aug 25, 2023 Discussed in #316 · 5 comments · Fixed by #318
Closed

Node in Nodes collection do not report a MIXED state, only IDLE or ALLOCATED #317

tazend opened this issue Aug 25, 2023 Discussed in #316 · 5 comments · Fixed by #318

Comments

@tazend
Copy link
Member

tazend commented Aug 25, 2023

Discussed in https://github.com/orgs/PySlurm/discussions/316

Originally posted by robgics August 25, 2023
I used the collection to load all nodes, and then I print out the state of all of them. They are all either IDLE, ALLOCATED, or some form of DOWN/DRAIN...but no MIXED. Inspecting particular nodes that I know are mixed (via scontrol show node) shows that if a node is MIXED (so even 1 cpu in use, out of 48), then it will appear as ALLOCATED via pyslurm.

I think we can work around this by comparing total cpus and allocated cpus. But I'm just wondering if this simplification is intentional or if I'm missing something.

Thanks!

@tazend
Copy link
Member Author

tazend commented Aug 25, 2023

mh, that is weird. Because I'm using the exact same function that scontrol is also using, and they just print the result of that function out.
I'll have to test that out on my Cluster.

@tazend
Copy link
Member Author

tazend commented Aug 25, 2023

@robgics

also found the error in this case - will make the fix tomorrow together with #315.
Thank you for spotting all the bugs :)

@robgics
Copy link
Contributor

robgics commented Aug 25, 2023

Heh, that's been the easy part for me. It's been being SURE it's a bug and not just a mistake I'm making that's been the hard part. Thanks for being so responsive. You fixed those bugs before I was able to make a dent in understanding the deeper workings of pyslurm.

@tazend
Copy link
Member Author

tazend commented Aug 26, 2023

Alright, fixed now in main, same with #315

@robgics
Copy link
Contributor

robgics commented Aug 29, 2023

Looks like it's working great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants