Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix retruning returns #1431

Merged
merged 2 commits into from
Apr 9, 2020
Merged

fix retruning returns #1431

merged 2 commits into from
Apr 9, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Apr 9, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes #1421.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the bug Something isn't working label Apr 9, 2020
@Borda Borda added this to the 0.7.3 milestone Apr 9, 2020
@Borda Borda requested review from williamFalcon and a team April 9, 2020 18:29
@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #1431 into master will not change coverage by %.
The diff coverage is 0%.

@@          Coverage Diff           @@
##           master   #1431   +/-   ##
======================================
  Coverage      92%     92%           
======================================
  Files          66      66           
  Lines        3508    3508           
======================================
  Hits         3212    3212           
  Misses        296     296           

@Borda Borda marked this pull request as ready for review April 9, 2020 18:41
@Borda
Copy link
Member Author

Borda commented Apr 9, 2020

0% of diff hit (target 40%) fails because we do not have covered by any test...

@williamFalcon
Copy link
Contributor

ok great. last pr before 0.7.3!

@Borda
Copy link
Member Author

Borda commented Apr 9, 2020

ok great. last pr before 0.7.3!

what about the 1412?

@williamFalcon williamFalcon merged commit b2707c9 into master Apr 9, 2020
@Borda Borda deleted the bugfix/run_training_batch branch April 10, 2020 09:10
@Borda Borda modified the milestones: 0.7.4, 0.7.3 Apr 10, 2020
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Jun 7, 2020
@Borda Borda modified the milestones: 0.7.3, v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run_training_batch breaks on None batch or -1 response from on_batch_start (in new 0.7.2 release)
2 participants