Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move Trains logger to Bolts #2384

Merged
merged 2 commits into from
Jun 27, 2020
Merged

move Trains logger to Bolts #2384

merged 2 commits into from
Jun 27, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Jun 27, 2020

What does this PR do?

Moving Trains logger from PL to Bolts Lightning-Universe/lightning-bolts#86

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Borda Borda added the let's do it! approved to implement label Jun 27, 2020
@Borda Borda requested a review from williamFalcon June 27, 2020 11:27
@mergify mergify bot requested a review from a team June 27, 2020 11:28
@Borda Borda marked this pull request as ready for review June 27, 2020 12:59
@codecov
Copy link

codecov bot commented Jun 27, 2020

Codecov Report

Merging #2384 into master will increase coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #2384    +/-   ##
=======================================
  Coverage      88%     88%            
=======================================
  Files          70      69     -1     
  Lines        5568    5452   -116     
=======================================
- Hits         4901    4818    -83     
+ Misses        667     634    -33     

@williamFalcon williamFalcon merged commit 41f5df1 into master Jun 27, 2020
@Borda Borda deleted the loggers/trains branch June 27, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
let's do it! approved to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants