Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remaning sklearn metrics #2562

Merged
merged 45 commits into from
Aug 5, 2020
Merged

Add remaning sklearn metrics #2562

merged 45 commits into from
Aug 5, 2020

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Jul 9, 2020 •
edited by Borda
Loading

What does this PR do?

This PR adds remaining metrics for sklearn backend

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Jul 9, 2020 •
edited
Loading

Hello @SkafteNicki! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-08-05 09:01:59 UTC

@mergify mergify bot requested a review from a team July 9, 2020 07:35
@mergify mergify bot requested a review from a team July 9, 2020 07:50
@Borda Borda added the feature Is an improvement or enhancement label Jul 9, 2020
@Borda Borda added this to the 0.8.x milestone Jul 9, 2020
@mergify
Copy link
Contributor

mergify bot commented Jul 9, 2020

This pull request is now in conflict... :(

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jul 22, 2020

This pull request is now in conflict... :(

@justusschock justusschock self-assigned this Jul 29, 2020
@SkafteNicki SkafteNicki changed the title [WIP] Add remaning sklearn metrics Add remaning sklearn metrics Aug 4, 2020
@codecov
Copy link

codecov bot commented Aug 5, 2020 •
edited
Loading

Codecov Report

Merging #2562 into master will increase coverage by 1%.
The diff coverage is 93%.

@@          Coverage Diff           @@
##           master   #2562   +/-   ##
======================================
+ Coverage      89%     90%   +1%     
======================================
  Files          78      78           
  Lines        6963    7000   +37     
======================================
+ Hits         6218    6317   +99     
+ Misses        745     683   -62

@SkafteNicki
Copy link
Member Author

@Borda and @justusschock this should be ready to merge now

@Borda Borda requested a review from justusschock August 5, 2020 07:56
Borda
Borda approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind add chlog note and list there all the newly added metrics 🐰

@mergify mergify bot requested a review from a team August 5, 2020 07:59
Borda
Borda reviewed Aug 5, 2020
View reviewed changes
tests/metrics/test_sklearn.py Outdated Show resolved Hide resolved
Borda
Borda reviewed Aug 5, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team August 5, 2020 08:03
@mergify mergify bot requested a review from a team August 5, 2020 08:11
rohitgr7
rohitgr7 approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Borda Borda changed the title Add remaning sklearn metrics Add remaning sklearn metrics [wip] Aug 5, 2020
@Borda Borda changed the title Add remaning sklearn metrics [wip] Add remaning sklearn metrics Aug 5, 2020
@Borda
Copy link
Member

Borda commented Aug 5, 2020

just fixed RMSE and ready to go 🎉

@Borda Borda merged commit e373278 into Lightning-AI:master Aug 5, 2020
@SkafteNicki SkafteNicki deleted the new_sklearn_metrics branch August 5, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@justusschock justusschock justusschock approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

@neggert neggert Awaiting requested review from neggert

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@yukw777 yukw777 Awaiting requested review from yukw777

Assignees

@SkafteNicki SkafteNicki

Labels
feature Is an improvement or enhancement
Projects
None yet
Milestone
pl:0.8.x
Development

Successfully merging this pull request may close these issues.
5 participants
@SkafteNicki @pep8speaks @Borda @justusschock @rohitgr7