-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bug: replaced bce_loss_with_logits with bce_loss #7096
Fixed bug: replaced bce_loss_with_logits with bce_loss #7096
Conversation
Why not remove the |
Codecov Report
@@ Coverage Diff @@
## master #7096 +/- ##
=======================================
- Coverage 91% 87% -5%
=======================================
Files 198 198
Lines 12634 12790 +156
=======================================
- Hits 11541 11067 -474
- Misses 1093 1723 +630 |
Some losses in torchmetrics are required probabilities rather than scores. |
I would go for the more numerically stable option. |
I removed sigmoid activation from the forward pass, but anyway, even |
great fix! |
What does this PR do?
Fixed bug in pl_examples/domain_templates/computer_vision_fine_tuning.py:
replaced binary_cross_entropy_with_logits with binary_cross_entropy.
See #7081