Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NeptuneLogger.log_text(step=None) #7194

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

alessiobonfiglio
Copy link
Contributor

@alessiobonfiglio alessiobonfiglio commented Apr 23, 2021

What does this PR do?

Remove an unwanted argument to the log_text() method of the neptune logger
Fixes #7193

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #7194 (889bb47) into master (f58865a) will decrease coverage by 5%.
The diff coverage is 67%.

@@           Coverage Diff           @@
##           master   #7194    +/-   ##
=======================================
- Coverage      92%     87%    -5%     
=======================================
  Files         197     198     +1     
  Lines       12626   12732   +106     
=======================================
- Hits        11632   11049   -583     
- Misses        994    1683   +689     

@awaelchli awaelchli added logger Related to the Loggers bug Something isn't working labels Apr 24, 2021
@awaelchli awaelchli added this to the v1.3 milestone Apr 24, 2021
@awaelchli
Copy link
Contributor

awaelchli commented Apr 24, 2021

Could you adjust the test in tests/logger/test_neptune.py? Remove the step=None from the call assertion in test_neptune_additional_methods :)

@Borda Borda requested a review from rohitgr7 April 25, 2021 05:59
Remove step=None from the call assertion
@alessiobonfiglio
Copy link
Contributor Author

Could you adjust the test in tests/logger/test_neptune.py? Remove the step=None from the call assertion in test_neptune_additional_methods :)

Done

@carmocca carmocca changed the title Fix log_text function in pytorch_lightning.loggers.neptune Fix NeptuneLogger.log_text(step=None) Apr 26, 2021
@carmocca carmocca merged commit ac7d6a3 into Lightning-AI:master Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logger Related to the Loggers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Neptune logger: "TypeError: log_text() got an unexpected keyword argument 'step'"
5 participants