-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NeptuneLogger.log_text(step=None)
#7194
Merged
carmocca
merged 1 commit into
Lightning-AI:master
from
alessiobonfiglio:pytorch-lightning
Apr 26, 2021
Merged
Fix NeptuneLogger.log_text(step=None)
#7194
carmocca
merged 1 commit into
Lightning-AI:master
from
alessiobonfiglio:pytorch-lightning
Apr 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7194 +/- ##
=======================================
- Coverage 92% 87% -5%
=======================================
Files 197 198 +1
Lines 12626 12732 +106
=======================================
- Hits 11632 11049 -583
- Misses 994 1683 +689 |
rohitgr7
reviewed
Apr 24, 2021
ee87386
to
6d3f29c
Compare
awaelchli
approved these changes
Apr 24, 2021
Could you adjust the test in tests/logger/test_neptune.py? Remove the |
Borda
approved these changes
Apr 25, 2021
Remove step=None from the call assertion
6d3f29c
to
889bb47
Compare
Done |
rohitgr7
approved these changes
Apr 25, 2021
NeptuneLogger.log_text(step=None)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove an unwanted argument to the log_text() method of the neptune logger
Fixes #7193
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list: