-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix] Add reloading support using BaseFinetuning #7253
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7253 +/- ##
=======================================
- Coverage 91% 90% -1%
=======================================
Files 199 199
Lines 12800 13014 +214
=======================================
+ Hits 11704 11746 +42
- Misses 1096 1268 +172 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the signature update could also have been in a separate PR, but LGTM
The only part I am not convinced about is passing the empty state to the hooks. This requires the user to change their implementation if I understand correctly. And it also requires us to update all our callbacks.
Co-authored-by: Adrian Wälchli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, small query
What does this PR do?
This PR adds support for reloading the optimizer_state when training with BaseFinetuning.
Fixes #6891
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃