Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prune data parallel #7510

Merged
merged 3 commits into from
May 13, 2021
Merged

prune data parallel #7510

merged 3 commits into from
May 13, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented May 12, 2021

What does this PR do?

prune deprecated data parallel

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the refactor label May 12, 2021
@Borda Borda added this to the v1.4 milestone May 12, 2021
@Borda Borda enabled auto-merge (squash) May 12, 2021 22:40
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #7510 (b2920e1) into master (d4ec751) will increase coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #7510    +/-   ##
=======================================
  Coverage      92%     92%            
=======================================
  Files         198     198            
  Lines       12843   13042   +199     
=======================================
+ Hits        11839   12024   +185     
- Misses       1004    1018    +14     

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it need a chlog entry?

@Borda Borda added the ready PRs ready to be merged label May 12, 2021
@Borda
Copy link
Member Author

Borda commented May 12, 2021

does it need a chlog entry?

I was not sure how to describe it :D
just removing these classes or would you suggest something more?

@awaelchli
Copy link
Contributor

what you added as description is perfect!

@Borda Borda merged commit 946aee0 into master May 13, 2021
@Borda Borda deleted the prune/dp branch May 13, 2021 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants