Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: horovod optimizer missing 2 required positional arguments #7840

Merged
merged 32 commits into from
Jul 21, 2021
Merged

Bugfix: horovod optimizer missing 2 required positional arguments #7840

merged 32 commits into from
Jul 21, 2021

Conversation

marsggbo
Copy link
Contributor

@marsggbo marsggbo commented Jun 5, 2021 •
edited by awaelchli
Loading

What does this PR do?

Fixes #7839, #7853

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 5, 2021 •
edited
Loading

Codecov Report

Merging #7840 (a1ee5b6) into master (4c79b3a) will decrease coverage by 4%.
The diff coverage is 56%.

@@           Coverage Diff           @@
##           master   #7840    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         217     217            
  Lines       14367   14375     +8     
=======================================
- Hits        13260   12659   -601     
- Misses       1107    1716   +609

@marsggbo marsggbo mentioned this pull request Jun 5, 2021
Closed
awaelchli
awaelchli reviewed Jun 5, 2021
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could simply add a trainer.test() call to an existing horovod test case :)

pytorch_lightning/plugins/training_type/horovod.py Outdated Show resolved Hide resolved
pytorch_lightning/plugins/training_type/horovod.py Outdated Show resolved Hide resolved
@awaelchli awaelchli added the bug Something isn't working label Jun 5, 2021
@awaelchli awaelchli added this to the v1.3.x milestone Jun 5, 2021
@awaelchli awaelchli added the 3rd party Related to a 3rd-party label Jun 5, 2021
@awaelchli
Copy link
Contributor

awaelchli commented Jun 5, 2021 •
edited
Loading

We should also be able to skip the whole optimizer wrapping when we are not training, i.e, there could be a check for `

if trainer.state.stage != RunningStage.TRAINING:
    # no need to setup optimizers
    return 
    
# otherwise setup optimizers

@awaelchli awaelchli added the distributed Generic distributed-related topic label Jun 5, 2021
tchaton
tchaton approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

tests/plugins/test_horovod.py Outdated Show resolved Hide resolved
@marsggbo marsggbo mentioned this pull request Jun 7, 2021
Closed
@mergify mergify bot added ready PRs ready to be merged has conflicts labels Jul 20, 2021
@Borda Borda changed the title Bugfix: issue #7839 horovod optimizer missing 2 required positional arguments Bugfix: horovod optimizer missing 2 required positional arguments Jul 20, 2021
tchaton
tchaton approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

pytorch_lightning/plugins/training_type/horovod.py Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Jul 20, 2021
@mergify mergify bot removed the has conflicts label Jul 21, 2021
@awaelchli awaelchli enabled auto-merge (squash) July 21, 2021 07:30
@awaelchli awaelchli merged commit d0038b5 into Lightning-AI:master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananthsub ananthsub ananthsub left review comments

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda approved these changes

@carmocca carmocca carmocca approved these changes

@tchaton tchaton tchaton approved these changes

@justusschock justusschock justusschock approved these changes

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@awaelchli awaelchli

Labels
3rd party Related to a 3rd-party bug Something isn't working distributed Generic distributed-related topic ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.3.x
8 participants
@marsggbo @awaelchli @ananthsub @Borda @carmocca @tchaton @justusschock @edenlightning