Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use XLA utility API to move data to CPU (Single TPU core) #8078

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

kaushikb11
Copy link
Contributor

What does this PR do?

Use XLA utility API to move data to CPU

Before submitting

  • [] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • [] Did you verify new and existing tests pass locally with your changes?
  • [] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #8078 (7e9d779) into master (5d44e61) will decrease coverage by 5%.
The diff coverage is 64%.

@@           Coverage Diff           @@
##           master   #8078    +/-   ##
=======================================
- Coverage      92%     87%    -5%     
=======================================
  Files         210     210            
  Lines       13593   13599     +6     
=======================================
- Hits        12466   11827   -639     
- Misses       1127    1772   +645     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@kaushikb11 kaushikb11 added the ready PRs ready to be merged label Jun 22, 2021
@kaushikb11 kaushikb11 enabled auto-merge (squash) June 22, 2021 20:57
@mergify mergify bot requested a review from a team June 22, 2021 20:58
@mergify mergify bot requested a review from a team June 22, 2021 21:36
@kaushikb11 kaushikb11 merged commit 8bce394 into Lightning-AI:master Jun 22, 2021
@carmocca carmocca added this to the v1.4 milestone Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: tpu Tensor Processing Unit ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants