-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] Add state_dict to loops #8197
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8197 +/- ##
=======================================
- Coverage 93% 88% -5%
=======================================
Files 212 212
Lines 13679 13695 +16
=======================================
- Hits 12720 12052 -668
- Misses 959 1643 +684 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you have examples of what types of state the loop needs to save/load?
Namely progress (dataclasses) and results ( trainer
loops:
fit_loop:
epoch_loop:
batch_loop:
val_loop:
...
validate_loop:
...
test_loop:
...
------
and each loop has:
a_loop:
progress
results |
113c569
to
3d748cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you describe how the trainer will resume the states? at what point is the loop's load_state_dict
called?
also does what requirements does this impose on composition of loops?
What does this PR do?
This PR adds the templating logic for loops state. This would be used by Fault Tolerant Logic.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃