Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel-perfect previews for PNG and other image files #610

Closed
justinraymondpark opened this issue Feb 12, 2020 · 11 comments
Closed

Pixel-perfect previews for PNG and other image files #610

justinraymondpark opened this issue Feb 12, 2020 · 11 comments

Comments

@justinraymondpark
Copy link

I love this app, it's essential for Windows. But it's not ideal for viewing small images designed for pixel art (for example, 16x16 or 32x32 dimensions). It appears to apply some kind of filter to the image, making it really blurry instead of crisp and clear.

It would be awesome to have the option to present these images accurately!
HumphreyFlat01 vs
32×32_ HumphreyFlat01 png 2020-02-12 01 30 35

@rabelux
Copy link
Member

rabelux commented Feb 12, 2020

Confirming this issue and want to add that it displays a weird zoom level of 1,250 % for a 16x16 png. The blurriness is probably no filter but the zoom level as initial zoom for a 32x32 is 625 % for me.
I also have the issue of a minimum window size being to small, but I guess that's a different topic.
grafik

@xupefei what was the reason to zoom images to fit the window size? And I guess this behaviour can be changed by setting private bool _zoomToFit = true to false in QuickLook.Plugin/QuickLook.Plugin.ImageViewer/ImagePanel.xaml.cs?

@Darklocq
Copy link

Yeah, this is pretty severe. I wouldn't want to see zooming disabled entirely, just no blurred like this.

@FeBe95
Copy link

FeBe95 commented Mar 3, 2020

I second this! Also, it would be nice to have a setting to disable zooming of small images in general. This should work for all images that fit on the screen (including some margin of ~5%). These should be displayed pixel-perfect (independent from Windows DPI settings).

Example

  • Screen size: 1920 x 1080
  • image1.png size: 512 x 512
  • image2.png size: 1024 x 1024
  • image3.png size: 2048 x 2048

Result

  • image1 gets displayed at 100%, pixel perfect, because its dimensions fit on the screen (both width and height)
  • image2's height is smaller than 1080 but there needs to be some space for the top bar of the QuickLook window and the Windows task bar etc., so render it at around 90%
  • image3 is bigger than the display size, so shrink it down to ~45%, same behavior as with image2.png

Currently small images are mostly zoomed to 125% for me, probably because that's my dpi setting in Windows. That makes them blurry and unpleasant to look at.

@lucius346346
Copy link

Can confirm the same issue on my desktop. I have 1440p screen set to 125% scaling. All images looks blurry. Also smaller ones are displayed 25% larger than they really are.

@xupefei
Copy link
Member

xupefei commented May 1, 2020

Try this one: https://ci.appveyor.com/project/xupefei/quicklook/builds/32586205/artifacts

Now you should be able to change the zoom level to exactly 100%.

@jir5024
Copy link

jir5024 commented May 2, 2020

Sooooo much better! thank you so much!

it does seem to max out at 300%, which for something like a 32x32 file is still pretty small - I wouldn't mind that being nudged up quite a lot. But this is soooo much better than it was, I'm not complaining :)

@lucius346346
Copy link

OK, now for some reason all images are rendered weirdly with this version. The edges are jagged.

Screenshot_1

@xupefei
Copy link
Member

xupefei commented May 2, 2020

It’s because I have changed the scaling anti-aliasing quality from high to low. I’ll change it back.

@xupefei
Copy link
Member

xupefei commented May 3, 2020

@lucius346346
Copy link

Picture is smooth but it's displayed at 125% zoom by default.

@xupefei
Copy link
Member

xupefei commented May 3, 2020

Yeah, the initial zoom is not 100%, but you are now able to adjust it to 100%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants